Correct clientReady hook in Auto Poll mode#94
Merged
Conversation
…cessful or failed fetch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #94 +/- ##
==========================================
+ Coverage 91.63% 91.75% +0.12%
==========================================
Files 18 18
Lines 1613 1613
Branches 406 408 +2
==========================================
+ Hits 1478 1480 +2
+ Misses 134 132 -2
Partials 1 1
☔ View full report in Codecov by Sentry. |
laliconfigcat
approved these changes
Oct 9, 2023
z4kn4fein
approved these changes
Oct 10, 2023
…xInitWaitTime is zero (maxInitWaitTime should take precedence over cache sync-up)
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the purpose of your pull request
So far the
clientReadyevent has fired in Auto Poll mode only when receiving 200, 304, 403 or 404 status code. In other cases (including the case of network errors)maxInitWaitTimehas been waited before firingclientReady.Breaking changes:
clientReadyhook to fire after the completion of the first fetch operation in Auto Poll mode - regardless of success or failure - to make the behavior consistent with other SDKs.Requirement checklist (only if applicable)